Skip to content

add LDAP integr. test for receiving share candidates with group limitation #15858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 2 commits into from
Jun 17, 2019
Merged

add LDAP integr. test for receiving share candidates with group limitation #15858

blizzz merged 2 commits into from
Jun 17, 2019

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Jun 3, 2019 •
edited
Loading

  • adds integration tests that verify group limitation on sharing works with LDAP groups (we have a regression :( ) – first commit
  • fixes it – second commit

@blizzz blizzz added this to the Nextcloud 17 milestone Jun 3, 2019
@blizzz blizzz force-pushed the enh/noid/ldap-sharee-limited-groups branch 7 times, most recently from d3aba6f to e4bb5ed Compare June 7, 2019 11:01
@blizzz blizzz force-pushed the enh/noid/ldap-sharee-limited-groups branch 2 times, most recently from 44516d7 to 6517f4c Compare June 13, 2019 14:50
@blizzz blizzz added 3. to review Waiting for reviews backport-request bug enhancement and removed 2. developing Work in progress labels Jun 13, 2019
@blizzz
Copy link
Member Author

blizzz commented Jun 13, 2019

/backport to stable16

@blizzz
Copy link
Member Author

blizzz commented Jun 13, 2019

/backport to stable15

skjnldsv
skjnldsv approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Let's see tests :)

@blizzz
Copy link
Member Author

blizzz commented Jun 13, 2019

Code looks good! Let's see tests :)

test case was added to integration-ldap-openldap-uid-features and all other integration tests (needed to move some things to traits) still pass. What fails is unrelated or times out.

blizzz added 2 commits June 14, 2019 06:23
@blizzz @skjnldsv
add LDAP integr. test for receiving share candidates with group limit…
437b33f 
…ation

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz @skjnldsv
fix inGroup check, thus make integration tests succeed
1d48c03 
there is not such strange return mode. Having invalid user ids caused this
check to fail, and as side effect share limitation to groups to not work.

Signed-off-by: Arthur Schiwon <[email protected]>
@skjnldsv skjnldsv force-pushed the enh/noid/ldap-sharee-limited-groups branch from 6517f4c to 1d48c03 Compare June 14, 2019 04:24
@skjnldsv
Copy link
Member

skjnldsv commented Jun 14, 2019 •
edited
Loading

Rebased to trigger drone

EDIT: passed https://drone.nextcloud.com/nextcloud/server/19244/60/5

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 17, 2019
@blizzz blizzz merged commit 2378012 into master Jun 17, 2019
@blizzz blizzz deleted the enh/noid/ldap-sharee-limited-groups branch June 17, 2019 13:33
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 17, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jun 17, 2019

backport to stable16 in #15984

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 17, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jun 17, 2019

backport to stable15 in #15985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@danxuliu danxuliu Awaiting requested review from danxuliu

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug enhancement feature: ldap regression

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz @skjnldsv @ChristophWurst