-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fall back to black for non-color values #16021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rullzer
merged 1 commit into
master
from
bugfix/noid/fall-back-to-black-for-non-color-values
Jun 25, 2019
Merged
Fall back to black for non-color values #16021
rullzer
merged 1 commit into
master
from
bugfix/noid/fall-back-to-black-for-non-color-values
Jun 25, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
skjnldsv
approved these changes
Jun 20, 2019
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense!!
rullzer
approved these changes
Jun 25, 2019
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
|
backport to stable16 in #16089 |
|
backport to stable15 in #16090 |
|
The backport to stable14 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue has no impact at the moment because our CSP blocks it. But validation is still a good thing to add.