Skip to content

[stable16] Better check reshare permissions #16127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 4 commits into from
Jun 27, 2019
Merged

[stable16] Better check reshare permissions #16127

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f97278
Correctly check share permissions when updating a re-sub-share
nickvergessen Jun 21, 2019
9bb690d
Do not create folders with admin user
danxuliu Jun 21, 2019
824c57d
Add integration test for increasing sub reshare permissions
danxuliu Jun 21, 2019
808280b
Fix sharing tests
rullzer Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not create folders with admin user 
The admin user is not deleted after each integration test is run, so
folders created by the admin user in one test are still there when the
next tests run; tests should be independent one from each other, so a
regular user that is created and deleted for each test should be used
instead.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu authored and Backportbot committed Jun 27, 2019
commit 9bb690d299085a9667918a8f540e3631ad0b2103
8 changes: 5 additions & 3 deletions build/integration/features/sharing-v1-part3.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,14 +339,16 @@ Feature: sharing

Scenario: do not allow to increase link share permissions on reshare
Given As an "admin"
And user "admin" created a folder "/TMP"
And user "user0" exists
And user "user1" exists
And user "user0" created a folder "/TMP"
And As an "user0"
And creating a share with
| path | TMP |
| shareType | 0 |
| shareWith | user0 |
| shareWith | user1 |
| permissions | 17 |
When As an "user0"
When As an "user1"
And creating a share with
| path | TMP |
| shareType | 3 |
Expand Down