Skip to content

Update operationprogressbar.js #16151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jul 15, 2019
Merged

Update operationprogressbar.js #16151

MorrisJobke merged 1 commit into from
Jul 15, 2019

Conversation

@jameslao
Copy link
Contributor

@jameslao jameslao commented Jun 28, 2019

To fix issue #16137

@ghjjkbbh

This comment has been minimized.

Sign in to view
@rullzer rullzer added the 3. to review Waiting for reviews label Jul 5, 2019
@rullzer rullzer added this to the Nextcloud 17 milestone Jul 5, 2019
@skjnldsv skjnldsv requested a review from georgehrke July 12, 2019 13:55
@skjnldsv skjnldsv added the bug label Jul 12, 2019
@jancborchardt
Copy link
Member

jancborchardt commented Jul 15, 2019

@georgehrke @ChristophWurst @juliushaertl could you review the JS here? Fixes a papercut issue for 17 polishing. :)

@georgehrke georgehrke requested a review from GretaD July 15, 2019 17:29
GretaD
GretaD approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks good, thank you jameslao

@MorrisJobke MorrisJobke mentioned this pull request Jul 15, 2019
Merged
28 tasks
MorrisJobke
MorrisJobke approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit cd3f5e4 into nextcloud:master Jul 15, 2019
@welcome
Copy link

welcome bot commented Jul 15, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@MorrisJobke MorrisJobke mentioned this pull request Jul 15, 2019
Closed
@dossantg
Copy link

dossantg commented Jul 17, 2019

We have the same issue on nextcloud 16.0.3.

Is it possible to add this fix to 16.0.4?

Regards,

@georgehrke
Copy link
Member

georgehrke commented Jul 17, 2019

/backport to stable16

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 17, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 17, 2019

backport to stable16 in #16437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@GretaD GretaD GretaD approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

9 participants

@jameslao @ghjjkbbh @jancborchardt @dossantg @georgehrke @MorrisJobke @GretaD @skjnldsv @rullzer