Skip to content

Prevent user with empty uid #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Oct 6, 2016
Merged

Prevent user with empty uid #1616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ae9a2c
Prevent user with empty uid
butonic Sep 29, 2016
82c29e1
Log the error with display name
nickvergessen Oct 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/user_ldap/lib/User/User.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* @author Joas Schilling <[email protected]>
* @author Morris Jobke <[email protected]>
* @author Thomas Müller <[email protected]>
* @author Jörn Friedrich Dreyer <[email protected]>
*
* @license AGPL-3.0
*
Expand All @@ -32,6 +33,7 @@
use OCP\IConfig;
use OCP\Image;
use OCP\IUserManager;
use OCP\Util;

/**
* User
Expand Down Expand Up @@ -111,6 +113,14 @@ public function __construct($username, $dn, IUserTools $access,
IConfig $config, FilesystemHelper $fs, Image $image,
LogWrapper $log, IAvatarManager $avatarManager, IUserManager $userManager) {

if ($username === null) {
$log->log("uid for '$dn' must not be null!", Util::ERROR);
throw new \InvalidArgumentException('uid must not be null!');
} else if ($username === '') {
$log->log("uid for '$dn' must not be an empty string", Util::ERROR);
throw new \InvalidArgumentException('uid must not be an empty string!');
}

$this->access = $access;
$this->connection = $access->getConnection();
$this->config = $config;
Expand Down