Prevent undefined offset 0 in findByUserIdOrMail #16308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
changed the title
kesselb
force-pushed
the
fix/undefined-offset-0
branch
from
7650049 to
a3689b9
Compare
kesselb
force-pushed
the
fix/undefined-offset-0
branch
from
a3689b9 to
1ce7d7a
Compare
kesselb
force-pushed
the
fix/undefined-offset-0
branch
from
1ce7d7a to
1bdf63a
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
fix/undefined-offset-0
branch
from
1bdf63a to
d57540a
Compare
compagnon
approved these changes
Jul 10, 2019
Member
|
/backport to stable16 |
Member
|
/backport to stable15 |
MorrisJobke
approved these changes
Jul 10, 2019
|
backport to stable16 in #16325 |
Member
|
/backport to stable15 |
|
backport to stable15 in #16326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced by #10743
Discovered by @compagnon #16260
array_filterpresevers the keys. If the first user is disabled and the second one enabled count will be 1 but index 0 undefined. Adjusted the tests to callfindByUserIdOrMaildirectly because theemailmethod catches any error and returns always success.