Don't send executionContexts for Clear-Site-Data #16310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
skjnldsv
approved these changes
Jul 9, 2019
rullzer
approved these changes
Jul 9, 2019
Contributor
Author
|
Oh. I have to adjust some tests ... 🙈 |
There are plans to remove executionContexts from the spec: w3c/webappsec-clear-site-data#59 Firefox already removed it https://bugzilla.mozilla.org/show_bug.cgi?id=1548034 Chromium implementation is not finish: https://bugs.chromium.org/p/chromium/issues/detail?id=898503&q=clear-site-data&sort=-modified&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
enh/drop-execution-context
branch
from
bfadc0c to
6235a66
Compare
skjnldsv
added
4. to release
Member
|
would it make sense to backport? |
Member
|
/backport to stable16 |
Member
|
/backport to stable15 |
|
backport to stable16 in #17157 |
|
backport to stable15 in #17158 |
haslersn
added a commit
to haslersn/nextcloud-server
that referenced
this pull request
Sep 14, 2023
This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: nextcloud#16310
haslersn
added a commit
to haslersn/nextcloud-server
that referenced
this pull request
Sep 14, 2023
This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: nextcloud#16310 Signed-off-by: Sebastian Hasler <[email protected]>
4 tasks
haslersn
added a commit
to haslersn/nextcloud-oidc-login
that referenced
this pull request
Sep 14, 2023
See https://github.com/nextcloud/server/blob/b085803c0bfe8c568e5710525e49d5f6378833b6/core/Controller/LoginController.php#L99 and following lines. Also note that setting `clearingExecutionContexts` is no longer required, because it had to do with the executionContexts feature which is no longer used by nextcloud since nextcloud/server#16310
haslersn
added a commit
to haslersn/nextcloud-oidc-login
that referenced
this pull request
Sep 14, 2023
See https://github.com/nextcloud/server/blob/b085803c0bfe8c568e5710525e49d5f6378833b6/core/Controller/LoginController.php#L99 and following lines. Also note that setting `clearingExecutionContexts` is no longer required, because it had to do with the executionContexts feature which is no longer used by nextcloud since nextcloud/server#16310. Furthermore, with the behavior introduced in nextcloud/server#12573, setting `clearingExecutionContexts` breaks our logout redirects, because the middleware subsequently (after the logout redirect) returns another redirects to `/login?clear=1`.
haslersn
added a commit
to haslersn/nextcloud-oidc-login
that referenced
this pull request
Sep 14, 2023
See https://github.com/nextcloud/server/blob/b085803c0bfe8c568e5710525e49d5f6378833b6/core/Controller/LoginController.php#L99 and following lines. Also note that setting `clearingExecutionContexts` is no longer required, because it had to do with the executionContexts feature which is no longer used by nextcloud since nextcloud/server#16310. Furthermore, with the behavior introduced in nextcloud/server#12573, setting `clearingExecutionContexts` breaks our logout redirects, because the middleware subsequently (after the logout redirect) returns another redirects to `/login?clear=1`.
kesselb
pushed a commit
to haslersn/nextcloud-server
that referenced
this pull request
Sep 14, 2023
This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: nextcloud#16310 Signed-off-by: Sebastian Hasler <[email protected]>
haslersn
added a commit
to haslersn/nextcloud-server
that referenced
this pull request
Nov 2, 2023
This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: nextcloud#16310 Signed-off-by: Sebastian Hasler <[email protected]>
haslersn
added a commit
to haslersn/nextcloud-server
that referenced
this pull request
Nov 2, 2023
This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: nextcloud#16310 Signed-off-by: Sebastian Hasler <[email protected]>
kesselb
pushed a commit
to haslersn/nextcloud-server
that referenced
this pull request
Apr 4, 2024
This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: nextcloud#16310 Signed-off-by: Sebastian Hasler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9179
There are plans to remove executionContexts from the spec: w3c/webappsec-clear-site-data#59
Firefox already removed it and Chromium never ended up implementing this.