Skip to content

Only prevent disabling encrytion via the API #16423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Jul 16, 2019
Merged

Only prevent disabling encrytion via the API #16423

rullzer merged 1 commit into from
Jul 16, 2019

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 16, 2019 •
edited
Loading

Fix #16410

regression from #16121

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Jul 16, 2019
@nickvergessen nickvergessen added this to the Nextcloud 17 milestone Jul 16, 2019
@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 16, 2019

/backport to stable16

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 16, 2019

/backport to stable15

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 16, 2019

/backport to stable14

@nickvergessen nickvergessen mentioned this pull request Jul 16, 2019
Closed
@MorrisJobke MorrisJobke mentioned this pull request Jul 16, 2019
Merged
28 tasks
MorrisJobke
MorrisJobke approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

rullzer
rullzer approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure...

@rullzer rullzer merged commit b73ef3d into master Jul 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/16410/allow-to-enable-encryption-in-the-UI branch July 16, 2019 17:43
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 16, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 16, 2019

backport to stable16 in #16425

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 16, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 16, 2019

backport to stable15 in #16426

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 16, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 16, 2019

backport to stable14 in #16427

@Nibbels
Copy link

Nibbels commented Aug 22, 2019 •
edited
Loading

Hey there,

I had exactly the problem described in
https://help.nextcloud.com/t/verschlusselung-lasst-sich-nicht-aktivieren/57971
using Nextcloud 16.0.3 which I downloaded and freshly installed yesterday.

(I wanted to activate encryption and got 403
The given key can not be set)

Then found this commit, manually copied the diff into my AppConfigController.php.
The problem vanished.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug regression

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

Can't enable server-side encryption on Nextcloud 16.0.2 and 16.0.3

5 participants

@nickvergessen @Nibbels @rullzer @MorrisJobke