Skip to content

Various fixes for transfer ownership #16439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LEDfan wants to merge 5 commits into from
Closed

Various fixes for transfer ownership #16439

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fb6e9e
Fix transfer-ownership for Group Folders
LEDfan Jul 17, 2019
061a919
Fix tests
LEDfan Jul 18, 2019
e1505ac
Add option to transfer-ownership to move data
LEDfan Jan 3, 2020
9c42e85
Prevent transferring data to user which never loggedin
LEDfan Jan 3, 2020
d89d987
Catch \Error in Transfer::restoreShares
LEDfan Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix transfer-ownership for Group Folders 
Because Group folders don't have owners, use the same system to check
the permissions of the node.

Signed-off-by: Tobia De Koninck <[email protected]>
  • Loading branch information
@LEDfan
LEDfan committed Jan 3, 2020
commit 5fb6e9e2a740a94a3a284a5862e4b93adc340500
2 changes: 1 addition & 1 deletion lib/private/Share20/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ protected function generalCreateChecks(\OCP\Share\IShare $share) {
$isFederatedShare = $share->getNode()->getStorage()->instanceOfStorage('\OCA\Files_Sharing\External\Storage');
$permissions = 0;
$mount = $share->getNode()->getMountPoint();
if (!$isFederatedShare && $share->getNode()->getOwner()->getUID() !== $share->getSharedBy()) {
if ($mount->getMountType() !== 'group' && !$isFederatedShare && $share->getNode()->getOwner()->getUID() !== $share->getSharedBy()) {
// When it's a reshare use the parent share permissions as maximum
$userMountPointId = $mount->getStorageRootId();
$userMountPoints = $userFolder->getById($userMountPointId);
Expand Down