Skip to content

Conversation

@schiessle
Copy link
Member

@schiessle schiessle added the 3. to review Waiting for reviews label Jun 20, 2016
@MorrisJobke
Copy link
Member

This is already fixed in #162

@schiessle
Copy link
Member Author

This is already fixed in #162

hm, #162 has less line changes and fixes multiple apps

@schiessle
Copy link
Member Author

@MorrisJobke #162 only fixes the federation app, this is about the federatedfilesharing app.

<id>federatedfilesharing</id>
<name>Federated File Sharing</name>
<description>Provide federated file sharing across ownCloud servers</description>
<description>Provide federated file sharing across Nextcloud servers</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we drop the name here completely? Because this should also involve 3rdparty servers in the future (like pydio) ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@MorrisJobke
Copy link
Member

This is already fixed in #162

THis is wrong. Sorry.

That PR looks good 👍

@schiessle schiessle force-pushed the fix-owncloud-references-federated branch from eaf0f2a to 9eaccaf Compare June 20, 2016 12:21
@vincchan
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants