Skip to content

Fix max contrast retrieval to limit minimum color for relative time #16532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Jul 25, 2019
Merged

Fix max contrast retrieval to limit minimum color for relative time #16532

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e02d71
Fix max contrast retrieval to limit minimum color for relative time
MorrisJobke Jul 24, 2019
003e235
Trigger fallback code to get max contrast value and use integer there
MorrisJobke Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Trigger fallback code to get max contrast value and use integer there 
Signed-off-by: Morris Jobke <[email protected]>
  • Loading branch information
@MorrisJobke
MorrisJobke committed Jul 25, 2019
commit 003e23520d12840a5806a46275db9c9499b5c17c
7 changes: 5 additions & 2 deletions apps/files/js/filelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,12 +1541,15 @@
try {
var maxContrastHex = window.getComputedStyle(document.documentElement)
.getPropertyValue('--color-text-maxcontrast').trim()
if (maxContrastHex.length < 4) {
throw Error();
}
var maxContrast = parseInt(maxContrastHex.substring(1, 3), 16)
} catch(error) {
var maxContrast = OCA.Accessibility
&& OCA.Accessibility.theme === 'themedark'
? '130'
: '118'
? 130
: 118
}

// size column
Expand Down