supresses disclosing the userid for LDAP users in the welcome mail #16551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The userid is not relevant here, and by default cannot be used to login with. Typically, there is a common type of login names in organizations (LDAP username or email most often) that does not need to be disclosed. Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
bug
3. to review
blizzz
requested review from
MorrisJobke,
juliusknorr,
nickvergessen and
skjnldsv
skjnldsv
approved these changes
Jul 26, 2019
skjnldsv
approved these changes
Jul 26, 2019
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Looks good to me!
There is no methods to check if the userid is valid of any use instead of hardcoding the ldap check?
Member
Author
That depends on the user backend, see the my description. I happily do a follow up PR with the proper solution, but right now I need something I can bring back to 16. |
Member
Author
|
/backport to stable16 |
juliusknorr
approved these changes
Jul 26, 2019
MorrisJobke
added
4. to release
|
backport to stable16 in #16561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The userid is not relevant here, and by default cannot be used to login
with. Typically, there is a common type of login names in organizations
(LDAP username or email most often) that does not need to be disclosed.
In order to be backportable I kept the solution simple. An advanced way would be to introduce another Interface for backends so that they can provide login information (login name, or perhaps type to not disclose more data than necessary in an email).
Fixes #12735 (the userid disclosre in sharing mentioned in the issue is already solved)