Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Jul 26, 2019

regex for the win :)

fixes #16529 (see also for repro steps)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and even tests :)

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 26, 2019
@MorrisJobke MorrisJobke merged commit 2e803dc into master Jul 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/16529/mask-keys branch July 26, 2019 13:16
@MorrisJobke
Copy link
Member

@blizzz Backport to 16? I would say so.

@MorrisJobke
Copy link
Member

/backport to stable16

@MorrisJobke
Copy link
Member

Just noticed the backport label. 🙈

@backportbot-nextcloud
Copy link

backport to stable16 in #16562

@blizzz
Copy link
Member Author

blizzz commented Jul 26, 2019

i'd also say nc 15 to prevent accidential leaking

@blizzz
Copy link
Member Author

blizzz commented Jul 26, 2019

/backport to stable15

@backportbot-nextcloud
Copy link

backport to stable15 in #16565

@CyrilBrulebois
Copy link

Thanks for the quick fix for #16529; the regex strikes me as suboptimal as it would not catch the (possibly unlikely) cases where one reaches s100 and above…

/^(s\d\d+)?ldap_agent_password$/'

would ensure detecting two or more digits after the initial s. (\d\d+ can also be written as \d{2,}, but that's maybe less readable for newcomers.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

user_ldap's ldap_agent_password not effectively tagged as sensitive data

5 participants