-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
use a pattern to identify sensitive config keys #16555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arthur Schiwon <[email protected]>
MorrisJobke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense 👍
rullzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense and even tests :)
|
@blizzz Backport to 16? I would say so. |
|
/backport to stable16 |
|
Just noticed the backport label. 🙈 |
|
backport to stable16 in #16562 |
|
i'd also say nc 15 to prevent accidential leaking |
|
/backport to stable15 |
|
backport to stable15 in #16565 |
|
Thanks for the quick fix for #16529; the regex strikes me as suboptimal as it would not catch the (possibly unlikely) cases where one reaches s100 and above… would ensure detecting two or more digits after the initial |
regex for the win :)
fixes #16529 (see also for repro steps)