Do not log all locked exceptions #16558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen for valid reasons (multiple users writing at the same time) with for example the text app. Apps should properly handle it. No reason to log it by default. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
MorrisJobke,
icewind1991,
juliusknorr and
nickvergessen
MorrisJobke
approved these changes
Jul 26, 2019
juliusknorr
approved these changes
Jul 26, 2019
Member
|
@kesselb Btw, are you going to come to our Nextcloud Conference in Berlin in September? https://nextcloud.com/conf-2019/ for contributors it’s free and there’s travel & hotel support! Would be really great to have you. 🚀 |
Member
Author
|
/backport to stable16 |
rullzer
added
4. to release
|
backport to stable16 in #16578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen for valid reasons (multiple users writing at the same
time) with for example the text app. Apps should properly handle it. No
reason to log it by default.
Signed-off-by: Roeland Jago Douma [email protected]