Skip to content

[stable15] Fix/xss/on favorite file #16611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Jul 30, 2019
Merged

[stable15] Fix/xss/on favorite file #16611

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46a8af5
fix XSS when adding a file with a malicious name to favorites
MaxFichtelmann Jul 29, 2019
cadd6fa
prevent potential XSS via unchecked use innerHTML
MaxFichtelmann Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix XSS when adding a file with a malicious name to favorites 
Signed-off-by: Max Fichtelmann <[email protected]>
  • Loading branch information
@MaxFichtelmann
MaxFichtelmann authored and Backportbot committed Jul 30, 2019
commit 46a8af58c91ef2d95e99bd68cc6a30c77655e599
2 changes: 1 addition & 1 deletion apps/files/js/tagsplugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
var innerTagA = document.createElement('A');
innerTagA.setAttribute("href", url);
innerTagA.setAttribute("class", "nav-icon-files svg");
innerTagA.innerHTML = appName;
innerTagA.innerHTML = _.escape(appName);

var length = listLIElements.length + 1;
var innerTagLI = document.createElement('li');
Expand Down