-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Emit moveToTrash event only for the deleting user #16664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
don't we need the user exists check anymore when requesting the user folder instance? |
Signed-off-by: Julius Härtl <[email protected]>
70e0962 to
b1832c8
Compare
|
Hm I currently fail to understand why that unit test is failing with that change :/ |
Signed-off-by: Roeland Jago Douma <[email protected]>
|
ok so the issue with the failing test is that the users storage gets initisialized thus for the final change of the lock the user mount is there. Causing the lock to be different. So assume 'testUser'
The last one fails because it wants to release the exclusive lock (which isn't there) |
|
/backport to stable16 |
|
/backport to stable15 |
|
backport to stable16 in #17099 |
|
backport to stable15 in #17100 |
This is the same issue as in #16624 which causes a huge loading time caused by iterating over all mounts for a file id for all users if getById is called on the RootFolder:
server/lib/private/Files/Node/Folder.php
Line 292 in e43b341
Since the moveToTrash event is only used in e2ee it should be fine to just check for the file in the users mount who is trying to delete the file.