Skip to content

Fix shares read permissions #16761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 7 commits into from
Oct 4, 2019
Merged

Fix shares read permissions #16761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba1ba1a
Add helper script to run integration tests on a Docker container
skjnldsv Aug 26, 2019
99404bd
Move sharing integration tests to their own directory
skjnldsv Aug 26, 2019
a7526d7
Do not expect a 200 HTTP status code when updating a share
danxuliu Sep 3, 2019
6d4f4c1
Add assorted integration tests for shares
danxuliu Sep 3, 2019
f02cff1
Extract check for whether a user with access to a share can edit it
skjnldsv Aug 26, 2019
b1069b2
Add checks for whether a user with access to a share can delete it
skjnldsv Aug 26, 2019
ff895ab
Fix shares read permissions
skjnldsv Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 60 additions & 60 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,20 +1123,20 @@ trigger:

---
kind: pipeline
name: integration-sharing-v1
name: integration-checksums-v1

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-sharing-v1
image: nextcloudci/integration-php7.1:2
- name: integration-checksums-v1
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/sharing-v1.feature
- ./run.sh features/checksums.feature

trigger:
branch:
Expand All @@ -1148,20 +1148,20 @@ trigger:

---
kind: pipeline
name: integration-sharing-v1-part2
name: integration-external-storage

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-sharing-v1-part2
image: nextcloudci/integration-php7.1:2
- name: integration-external-storage
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/sharing-v1-part2.feature
- ./run.sh features/external-storage.feature

trigger:
branch:
Expand All @@ -1173,20 +1173,20 @@ trigger:

---
kind: pipeline
name: integration-sharing-v1-part3
name: integration-provisioning-v1

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-sharing-v1-part3
image: nextcloudci/integration-php7.1:2
- name: integration-provisioning-v1
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/sharing-v1-part3.feature
- ./run.sh features/provisioning-v1.feature

trigger:
branch:
Expand All @@ -1198,20 +1198,20 @@ trigger:

---
kind: pipeline
name: integration-checksums-v1
name: integration-tags

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-checksums-v1
image: nextcloudci/integration-php7.1:2
- name: integration-tags
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/checksums.feature
- ./run.sh features/tags.feature

trigger:
branch:
Expand All @@ -1223,20 +1223,20 @@ trigger:

---
kind: pipeline
name: integration-external-storage
name: integration-caldav

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-external-storage
image: nextcloudci/integration-php7.1:2
- name: integration-caldav
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/external-storage.feature
- ./run.sh features/caldav.feature

trigger:
branch:
Expand All @@ -1248,20 +1248,20 @@ trigger:

---
kind: pipeline
name: integration-provisioning-v1
name: integration-comments

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-provisioning-v1
image: nextcloudci/integration-php7.1:2
- name: integration-comments
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/provisioning-v1.feature
- ./run.sh features/comments.feature

trigger:
branch:
Expand All @@ -1273,20 +1273,20 @@ trigger:

---
kind: pipeline
name: integration-tags
name: integration-comments-search

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-tags
image: nextcloudci/integration-php7.1:2
- name: integration-comments-search
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/tags.feature
- ./run.sh features/comments-search.feature

trigger:
branch:
Expand All @@ -1298,20 +1298,20 @@ trigger:

---
kind: pipeline
name: integration-caldav
name: integration-favorites

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-caldav
image: nextcloudci/integration-php7.1:2
- name: integration-favorites
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/caldav.feature
- ./run.sh features/favorites.feature

trigger:
branch:
Expand All @@ -1323,20 +1323,20 @@ trigger:

---
kind: pipeline
name: integration-comments
name: integration-provisioning-v2

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-comments
image: nextcloudci/integration-php7.1:2
- name: integration-provisioning-v2
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/comments.feature
- ./run.sh features/provisioning-v2.feature

trigger:
branch:
Expand All @@ -1348,20 +1348,20 @@ trigger:

---
kind: pipeline
name: integration-comments-search
name: integration-webdav-related

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-comments-search
image: nextcloudci/integration-php7.1:2
- name: integration-webdav-related
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/comments-search.feature
- ./run.sh features/webdav-related.feature

trigger:
branch:
Expand All @@ -1373,20 +1373,20 @@ trigger:

---
kind: pipeline
name: integration-favorites
name: integration-sharees-features

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-favorites
image: nextcloudci/integration-php7.1:2
- name: integration-sharees-features
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/favorites.feature
- ./run.sh sharees_features/sharees.feature

trigger:
branch:
Expand All @@ -1398,20 +1398,20 @@ trigger:

---
kind: pipeline
name: integration-provisioning-v2
name: integration-sharees-v2-features

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-provisioning-v2
image: nextcloudci/integration-php7.1:2
- name: integration-sharees-v2-features
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/provisioning-v2.feature
- ./run.sh sharees_features/sharees_provisioningapiv2.feature

trigger:
branch:
Expand All @@ -1423,20 +1423,20 @@ trigger:

---
kind: pipeline
name: integration-webdav-related
name: integration-sharing-v1

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-webdav-related
image: nextcloudci/integration-php7.1:2
- name: integration-sharing-v1
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/webdav-related.feature
- ./run.sh sharing_features/sharing-v1.feature

trigger:
branch:
Expand All @@ -1448,20 +1448,20 @@ trigger:

---
kind: pipeline
name: integration-sharees-features
name: integration-sharing-v1-part2

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-sharees-features
image: nextcloudci/integration-php7.1:2
- name: integration-sharing-v1-part2
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh sharees_features/sharees.feature
- ./run.sh sharing_features/sharing-v1-part2.feature

trigger:
branch:
Expand All @@ -1473,20 +1473,20 @@ trigger:

---
kind: pipeline
name: integration-sharees-v2-features
name: integration-sharing-v1-part3

steps:
- name: submodules
image: docker:git
commands:
- git submodule update --init
- name: integration-sharees-v2-features
image: nextcloudci/integration-php7.1:2
- name: integration-sharing-v1-part3
image: nextcloudci/integration-php7.1:1
commands:
- bash tests/drone-run-integration-tests.sh || exit 0
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh sharees_features/sharees_provisioningapiv2.feature
- ./run.sh sharing_features/sharing-v1-part3.feature

trigger:
branch:
Expand Down
Loading