frame-src doesn't respect the nonce attribute #16766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <[email protected]>
Merged
rullzer
added
3. to review
skjnldsv
approved these changes
Aug 18, 2019
Contributor
|
Hmm. Code looks good. As per https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-src nonce is supported 😕 |
Member
|
@kesselb Probably a copy-paste issue since the description of the nonce seems to be related to inline scripts: "A whitelist for specific inline scripts..." At least firefox and chrome don't respect the nonce on frames. |
juliusknorr
approved these changes
Aug 19, 2019
Member
Author
|
@kesselb yeah it is listed everywhere (see for example also https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/img-src ) but doesn't work yet... |
Contributor
Indeed. They included the sources from "default-src" for "img-src" and "frame-src" 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma [email protected]