Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 20, 2019

Not sure how this worked in the past, but it seems to be broken in the original fix aswell:
95c9e0e

Anyway clearing the data and afterwards removing empty apps solves the issue for me.

Fix #16771


When you try to test this, you need to comment out the caching:

// If the timestamp is older than 300 seconds request the files new
if ((int)$jsonBlob['timestamp'] > ($this->timeFactory->getTime() - self::INVALIDATE_AFTER_SECONDS)) {
return $jsonBlob['data'];
}
if (isset($jsonBlob['ETag'])) {
$ETag = $jsonBlob['ETag'];
$content = json_encode($jsonBlob['data']);
}

And make sure you are on the beta channel:
OC_Util::loadVersion();
return \OC::$server->getConfig()->getSystemValue('updater.release.channel', self::$versionCache['OC_Channel']);

If you do this on stable16 with talk enable, it will correctly tell you talk has no 17 update atm.

@nickvergessen
Copy link
Member Author

/backport to stable16

@nickvergessen
Copy link
Member Author

/backport to stable15

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works 👍

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 20, 2019
@rullzer rullzer merged commit dd02920 into master Aug 20, 2019
@rullzer rullzer deleted the bugfix/16771/correctly-remove-apps-without-any-releases branch August 20, 2019 20:29
@backportbot-nextcloud
Copy link

backport to stable16 in #16818

@rullzer rullzer mentioned this pull request Aug 22, 2019
@rullzer
Copy link
Member

rullzer commented Oct 22, 2019

/backport to stable15

@backportbot-nextcloud
Copy link

The backport to stable15 failed. Please do this backport manually.

@rullzer
Copy link
Member

rullzer commented Oct 22, 2019

Needs a manual backport to stable15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: apps management feature: install and update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NC17Beta1: falsley "all apps have an update"

4 participants