-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Correctly remove apps without any releases #16811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rullzer
merged 1 commit into
master
from
bugfix/16771/correctly-remove-apps-without-any-releases
Aug 20, 2019
Merged
Correctly remove apps without any releases #16811
rullzer
merged 1 commit into
master
from
bugfix/16771/correctly-remove-apps-without-any-releases
Aug 20, 2019
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
rullzer
approved these changes
Aug 20, 2019
tobiasKaminsky
approved these changes
Aug 20, 2019
Member
tobiasKaminsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & works 👍
|
backport to stable16 in #16818 |
Merged
Member
|
/backport to stable15 |
|
The backport to stable15 failed. Please do this backport manually. |
Member
|
Needs a manual backport to stable15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
feature: apps management
feature: install and update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how this worked in the past, but it seems to be broken in the original fix aswell:
95c9e0e
Anyway clearing the data and afterwards removing empty apps solves the issue for me.
Fix #16771
When you try to test this, you need to comment out the caching:
server/lib/private/App/AppStore/Fetcher/Fetcher.php
Lines 154 to 162 in 8e278a2
And make sure you are on the beta channel:
server/lib/private/legacy/util.php
Lines 524 to 525 in d040954
If you do this on stable16 with talk enable, it will correctly tell you talk has no 17 update atm.