Add app name to the call #1683
Merged
Add app name to the call #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from 69b063f Signed-off-by: Joas Schilling <[email protected]>
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @georgehrke and @icewind1991 to be potential reviewers. |
Member
|
Tested and works 👍 |
MorrisJobke
approved these changes
Oct 10, 2016
mightyBroccoli
approved these changes
Oct 10, 2016
mightyBroccoli
left a comment
mightyBroccoli
left a comment
There was a problem hiding this comment.
By doing this change it is possible to use the Appstore with appcodechecker enabled atleast for my 5 machines this change is perfect.
nickvergessen
added
4. to release
Member
|
LGTM |
This was referenced May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from 69b063f aka #1225
Fix #1437
Steps
./occ config:system:set appcodechecker --value true --type boolean@MorrisJobke @rullzer @LukasReschke