Skip to content

Remove orphaned calendar data from deleted subscriptions #16835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 2 commits into from
Sep 4, 2019
Merged

Remove orphaned calendar data from deleted subscriptions #16835

rullzer merged 2 commits into from
Sep 4, 2019

Conversation

@tcitworld
Copy link
Member

@tcitworld tcitworld commented Aug 22, 2019

Closes #16833. Ref #13511

@tcitworld tcitworld added 3. to review Waiting for reviews bug labels Aug 22, 2019
@tcitworld
Copy link
Member Author

tcitworld commented Aug 22, 2019 •
edited
Loading

On my production database, 6M rows of calendarobjects, and 14M rows of calendarchanges are affected.
Didn't add the proper check, nothing affected. 🙈

tcitworld
tcitworld commented Aug 22, 2019
View reviewed changes
@tcitworld tcitworld force-pushed the bugfix/16833/remove-orphan-event-data-from-subscriptions branch from 5b1f59c to 456fb7e Compare August 22, 2019 10:27
nickvergessen
nickvergessen requested changes Aug 22, 2019
View reviewed changes
nickvergessen
nickvergessen reviewed Aug 22, 2019
View reviewed changes
@tcitworld tcitworld force-pushed the bugfix/16833/remove-orphan-event-data-from-subscriptions branch 2 times, most recently from a66b946 to 7624322 Compare August 23, 2019 13:13
georgehrke
georgehrke reviewed Aug 26, 2019
View reviewed changes
@georgehrke
Copy link
Member

georgehrke commented Aug 26, 2019

Otherwise this looks like a reasonable change to me 👍

@tcitworld tcitworld force-pushed the bugfix/16833/remove-orphan-event-data-from-subscriptions branch from 7624322 to e2b539b Compare August 26, 2019 08:42
@nickvergessen
Copy link
Member

nickvergessen commented Aug 26, 2019

/backport to stable16

@BernieO
Copy link
Contributor

BernieO commented Aug 26, 2019

Thanks for addressing this (#16833) so quickly 👍

Could this also be backported to stable15? Caching webcal calendars was introduced in NC15. So it would definitely make sense to backport it also to NC15

@tcitworld tcitworld added this to the Nextcloud 17 milestone Aug 28, 2019
@rullzer rullzer mentioned this pull request Aug 29, 2019
Merged
16 tasks
@rullzer rullzer merged commit 0e19e55 into master Sep 4, 2019
@rullzer rullzer deleted the bugfix/16833/remove-orphan-event-data-from-subscriptions branch September 4, 2019 08:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 4, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 4, 2019

backport to stable16 in #16994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@georgehrke georgehrke georgehrke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

remove orphaned events also from deleted webcal calendars

6 participants

@tcitworld @georgehrke @nickvergessen @BernieO @rullzer