Be sure to get the jailed path if the storage is a jail #16932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Aug 30, 2019
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Works for shares and group folders
juliusknorr
force-pushed
the
fix/workflow/jails
branch
from
ddb21b6 to
9ddcd3a
Compare
Member
|
I've amended to also use the same approach in the mime type check. |
Member
|
Should this then just happen outside this method and we only ever inject the jailed path? |
Member
Author
would make sense yes. |
Fixes: nextcloud/groupfolders#583 Signed-off-by: Roeland Jago Douma <[email protected]>
nickvergessen
force-pushed
the
fix/workflow/jails
branch
from
9ddcd3a to
f57fa23
Compare
Member
|
Done, please re-review @rullzer @juliushaertl |
Member
Author
|
Perfect :) |
juliusknorr
approved these changes
Sep 3, 2019
Member
|
/backport to stable16 |
Member
|
/backport to stable15 |
nickvergessen
added
4. to release
|
backport to stable16 in #16991 |
|
backport to stable15 in #16992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nextcloud/groupfolders#583
Signed-off-by: Roeland Jago Douma [email protected]