Skip to content

When you click on thumbnail of a file, it should open the file not the sidebar #16969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Sep 3, 2019
Merged

When you click on thumbnail of a file, it should open the file not the sidebar #16969

rullzer merged 1 commit into from
Sep 3, 2019

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 2, 2019

ref #14350

Change filelist _onClickFile function so thumbnail to open the file instead of the sidebar

@GretaD GretaD requested review from ChristophWurst, jancborchardt and juliusknorr and removed request for juliusknorr September 2, 2019 13:19
jancborchardt
jancborchardt approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good detail fix!

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish papercut Annoying recurring UX issue with possibly simple fix. labels Sep 2, 2019
@juliusknorr juliusknorr added this to the Nextcloud 17 milestone Sep 2, 2019
@szaimen
Copy link
Contributor

szaimen commented Sep 2, 2019

Any chance for a backport to stable16?

@rullzer rullzer merged commit 6093acd into master Sep 3, 2019
@rullzer rullzer deleted the bugfix/14350/thumbnail_should_open_thefile_not_sidebar branch September 3, 2019 05:52
@rullzer rullzer mentioned this pull request Sep 4, 2019
Merged
16 tasks
@kesselb kesselb mentioned this pull request Sep 8, 2019
Closed
@jancborchardt
Copy link
Member

jancborchardt commented Sep 10, 2019

/backport to stable16

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 10, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 10, 2019

backport to stable16 in #17091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

6 participants

@GretaD @szaimen @jancborchardt @juliusknorr @rullzer