Skip to content

Fix opening apps with Ctrl+click #17086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 1 commit into from
Sep 10, 2019
Merged

Fix opening apps with Ctrl+click #17086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/js/dist/main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/js/dist/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions core/src/components/MainMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,6 @@ export const setUp = () => {
$app = $app.closest('a')
}

// trigger redirect
// needed for ie, but also works for every browser
window.location = $app.href

if (event.which === 1 && !event.ctrlKey && !event.metaKey && $app.parent('#more-apps').length === 0) {
$app.find('svg').remove()
$app.find('div').remove() // prevent odd double-clicks
Expand All @@ -89,6 +85,9 @@ export const setUp = () => {
? 'icon-loading-small'
: 'icon-loading-small-dark'
))
// trigger redirect
// needed for ie, but also works for every browser
window.location = $app.attr('href')
} else {
// Close navigation when opening app in
// a new tab
Expand Down