Skip to content

Conversation

@nickvergessen
Copy link
Member

  1. Break your data directory e.g. (chmod ugo-rwx -R data/)
  2. Visit index.php
  3. Visit index.php/apps/files (e.g. from a bookmark

Before

Bildschirmfoto von 2019-09-16 19-39-24

After

Bildschirmfoto von 2019-09-16 19-39-29

Also I had an issue when my data dir is not mounted at all. So I added a second level fallback, when showing the error page also fails, we just print the plain messages.

Bildschirmfoto von 2019-09-16 19-43-43

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds legit

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...
🐘

@rullzer rullzer merged commit 48a00b8 into master Sep 23, 2019
@rullzer rullzer deleted the bugfix/noid/print-error-on-data-dir-error branch September 23, 2019 08:09
joshtrichards added a commit to joshtrichards/nc-server that referenced this pull request Jun 16, 2023
Fixes nextcloud#2180
And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708

Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc.

While we check for it later, it's too late for session.

Inspired by nextcloud#17163

Signed-off-by: Josh Richards <[email protected]>
joshtrichards added a commit to joshtrichards/nc-server that referenced this pull request Jun 16, 2023
Fixes nextcloud#2180
And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708

Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc.

While we check for it later, it's too late for session.

Inspired by nextcloud#17163

Signed-off-by: Josh Richards <[email protected]>
AndyScherzinger pushed a commit to joshtrichards/nc-server that referenced this pull request Feb 27, 2024
Fixes nextcloud#2180
And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708

Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc.

While we check for it later, it's too late for session.

Inspired by nextcloud#17163

Signed-off-by: Josh Richards <[email protected]>
skjnldsv pushed a commit to joshtrichards/nc-server that referenced this pull request Aug 16, 2024
Fixes nextcloud#2180
And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708

Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc.

While we check for it later, it's too late for session.

Inspired by nextcloud#17163

Signed-off-by: Josh Richards <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants