Fix getById for files in appdata and the root mount #17175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the path we are currently in is inside the appdata_* folder, the original getById method does not work, because it can only look inside the user's mount points. But the user has no mount point for the root storage. So in that case we directly check the mount of the root if it contains the id. If it does we check if the path is inside the path we are working in. Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
bug
3. to review
12 tasks
icewind1991
approved these changes
Sep 17, 2019
rullzer
deleted the
feature/noid/make-getById-work-for-files-in-appdata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the path we are currently in is inside the appdata_* folder,
the original getById method does not work, because it can only look inside
the user's mount points. But the user has no mount point for the root storage.
So in that case we directly check the mount of the root if it contains
the id. If it does we check if the path is inside the path we are working
in.
Required for nextcloud/spreed#1811