Skip to content

Fix l10n in federated file sharing #17207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Sep 19, 2019
Merged

Fix l10n in federated file sharing #17207

nickvergessen merged 1 commit into from
Sep 19, 2019

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 19, 2019

Otherwise it uses the core l10n files.

@ChristophWurst
Fix l10n in federated file sharing
a5869be 
Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Sep 19, 2019
@ChristophWurst ChristophWurst self-assigned this Sep 19, 2019
georgehrke
georgehrke approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Sep 19, 2019

/backport to stable17

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Sep 19, 2019

/backport to stable16

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Sep 19, 2019

/backport to stable15

@nickvergessen
Copy link
Member

nickvergessen commented Sep 19, 2019

Oh wow

@nickvergessen
Copy link
Member

nickvergessen commented Sep 19, 2019

There was 1 error:

  1. OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreate

Seems related

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Sep 19, 2019

Seems related

Seems like a random failure. Passes now?

@nickvergessen nickvergessen merged commit f750193 into master Sep 19, 2019
@nickvergessen nickvergessen deleted the fix/federated-file-sharing-l10n branch September 19, 2019 13:27
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 19, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 19, 2019

backport to stable17 in #17210

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 19, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 19, 2019

backport to stable16 in #17211

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 19, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 19, 2019

backport to stable15 in #17212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@georgehrke georgehrke georgehrke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review Waiting for reviews bug feature: language/translations (l10n/i18n) Localization and translation matters feature: sharing

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst @nickvergessen @georgehrke