Skip to content

Revert "[stable17] Bring the default font size up to 15px" #17330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Sep 30, 2019
Merged

Revert "[stable17] Bring the default font size up to 15px" #17330

skjnldsv merged 1 commit into from
Sep 30, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 30, 2019

Reverts #17309

Georg Ehrke:
Why was this backported? github.com//pull/17309

As Jan-C. Borchardt pointed out in github.com//issues/17236, most of the other stuff is sized in pixels, so this backport is likely to break the design of some apps in a minor update from 17.0.0 to 17.0.1.

@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Sep 30, 2019
@skjnldsv skjnldsv added this to the Nextcloud 17.0.1 milestone Sep 30, 2019
@skjnldsv skjnldsv self-assigned this Sep 30, 2019
georgehrke
georgehrke reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci 👍

@georgehrke georgehrke self-requested a review September 30, 2019 09:08
georgehrke
georgehrke approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci 👍

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 30, 2019
@skjnldsv skjnldsv merged commit e9b27b2 into stable17 Sep 30, 2019
@skjnldsv skjnldsv deleted the revert-17309-backport/17228/stable17 branch September 30, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgehrke georgehrke georgehrke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 17.0.1

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv @georgehrke @ChristophWurst @kesselb @marcoambrosini