Skip to content

Conversation

@alx-tuilmenau
Copy link
Contributor

@alx-tuilmenau alx-tuilmenau commented Sep 30, 2019

If a user is in circle A and a folder is shared to this circle with re-sharing permission, the user cannot re-share the folder or a subfolder without this line. There is a error message in the log:

{"reqId":"R0th0ufni5warwevBqni","level":3,"time":"2019-09-27T07:46:38+00:00","remoteAddr":"xxx.xx.xx.xx","user":"xxx","app":"PHP","method":"POST","url":"\/ocs\/v2.php\/apps\/f/v1\/shares?format=json","message":"Undefined variable: permissions at \/data\/nextcloud_16\/lib\/private\/Share20\/Manager.php#325","userAgent":"Mozilla\/5.0 (Macintosh; Intel MppleWebKit\/605.1.15 (KHTML, like Gecko) Version\/13.0 Safari\/605.1.15","version":"16.0.4.1"}
{"reqId":"R0th0ufni5warwevBqni","level":3,"time":"2019-09-27T07:46:38+00:00","remoteAddr":"xxx.xx.xx.xx","user":"xxx","app":"PHP","method":"POST","url":"\/ocs\/v2.php\/apps\/f/v1\/shares?format=json","message":"Error: Unsupported operand types at \/data\/nextcloud_16\/lib\/private\/Share20\/Manager.php#325","userAgent":"Mozilla\/5.0 (Macintosh; Intel AppleWebKit\/605.1.15 (KHTML, like Gecko) Version\/13.0 Safari\/605.1.15","version":"16.0.4.1"}

@gary-kim gary-kim added 3. to review Waiting for reviews bug labels Sep 30, 2019
@gary-kim
Copy link
Member

@alx-tuilmenau Thank you for your contribution.
Could you add a DCO sign-off to your commit? The easiest way would be to add the -s flag from the command line. Since you already made this commit, you can run the following command to add a DCO: git commit -s --amend then git push --force.
Otherwise, you can also add the following to the bottom of your commit message.

Signed-off-by: Random J Developer <[email protected]>

@alx-tuilmenau
Copy link
Contributor Author

@gary-kim I'm sorry, I copied the line from my test machine to the github web interface, I didn't use the git client. I don't know how to update the commit message within the github web.

@gary-kim gary-kim added this to the Nextcloud 18 milestone Sep 30, 2019
@gary-kim
Copy link
Member

I'm not sure if you can amend commits in the GitHub web interface. The easiest thing to to may be to clone the repo on your computer and amend your commit message.

Allow Re-Sharing of folders shared by circle

Signed-off-by: Alexander Fleischer <[email protected]>
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would like to have a final say from @daita

@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 2, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Dec 7, 2019

Ping @daita !

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 7, 2019
@ArtificialOwl
Copy link
Member

duplicate of (already merged) #17735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants