-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Allow Re-Sharing of folders shared by circle #17335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@alx-tuilmenau Thank you for your contribution. |
|
@gary-kim I'm sorry, I copied the line from my test machine to the github web interface, I didn't use the git client. I don't know how to update the commit message within the github web. |
|
I'm not sure if you can amend commits in the GitHub web interface. The easiest thing to to may be to clone the repo on your computer and amend your commit message. |
Allow Re-Sharing of folders shared by circle Signed-off-by: Alexander Fleischer <[email protected]>
0c98d34 to
9467d0a
Compare
blizzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would like to have a final say from @daita
|
Ping @daita ! |
|
duplicate of (already merged) #17735 |
If a user is in circle A and a folder is shared to this circle with re-sharing permission, the user cannot re-share the folder or a subfolder without this line. There is a error message in the log: