Remove users management settings cleaning leftovers #17360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
requested review from
ChristophWurst,
georgehrke,
juliusknorr,
nickvergessen and
rullzer
rullzer
reviewed
Oct 1, 2019
| @@ -1,237 +0,0 @@ | |||
| <!-- | |||
Member
Author
There was a problem hiding this comment.
No, it's because when I rebased, @ChristophWurst's migration of settings to apps was understood by the auto rebase, so the files I edited before were moved into the apps folder too.
But since I also renamed the files in /settings, it did not understood they needed to be replaced in the new /apps/settings location.
Member
Author
There was a problem hiding this comment.
So yes, they should really be removed, they are leftovers
https://github.com/nextcloud/server/blob/master/apps/settings/src/components/AppDetails.vue
ChristophWurst
approved these changes
Oct 2, 2019
rullzer
approved these changes
Oct 2, 2019
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #17263