-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Make sure we only use numbers as length #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @PVince81 and @owncloud-bot to be potential reviewers. |
|
@nickvergessen . Sorry, does not help for #1707 . As soon as the filesize exceeds 32 bit, a 0 byte file is downloaded. Also, if i mount the DAV endpoint in OSX, an error message is thrown instead of downloading the file. I have tried to understand the Architecture, in order to find things out for myself, but i didn´t get it right now. |
Signed-off-by: Joas Schilling <[email protected]>
310f01b to
05223a3
Compare
|
Added the unit tests, ready for review since this is fixing a different issue. |
Current coverage is 57.35% (diff: 100%)@@ master #1740 diff @@
==========================================
Files 1075 1075
Lines 61314 61315 +1
Methods 6865 6865
Messages 0 0
Branches 0 0
==========================================
+ Hits 35163 35165 +2
+ Misses 26151 26150 -1
Partials 0 0
|
|
Tested and works 👍 |
|
@karlitschek We should backport this to stable9 and stable10 @nickvergessen Could you open the backport PRs? Thanks |
|
please backport 👍 |
A try to fix #1707