Skip to content

Deprecate a lot of global js #17402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Oct 14, 2019
Merged

Deprecate a lot of global js #17402

rullzer merged 1 commit into from
Oct 14, 2019

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 4, 2019

🎵 We don't need no water, let the .... 🎵

@rullzer rullzer added 3. to review Waiting for reviews technical debt labels Oct 4, 2019
@rullzer rullzer added this to the Nextcloud 18 milestone Oct 4, 2019
ChristophWurst
ChristophWurst reviewed Oct 4, 2019
View reviewed changes
skjnldsv
skjnldsv approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@rullzer rullzer requested a review from ChristophWurst October 4, 2019 17:32
@rullzer rullzer changed the title Deprecate global jstimezonedetect Deprecate a lot of global js Oct 5, 2019
@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 7, 2019

Mind using setDeprecatedProp instead? Then you get the warning as soon as you access the global. Reasoning: not everything is a function. Prime example: Backbone. You might use Backbone.Model or Backbone.Collection, but never do a Backbone(), hence the deprecate helper won't catch the access.

@rullzer
Copy link
Member Author

rullzer commented Oct 7, 2019

Mind using setDeprecatedProp instead? Then you get the warning as soon as you access the global. Reasoning: not everything is a function. Prime example: Backbone. You might use Backbone.Model or Backbone.Collection, but never do a Backbone(), hence the deprecate helper won't catch the access.

right makes sense.

@ChristophWurst

This comment has been minimized.

Sign in to view
@rullzer rullzer force-pushed the td/js_deprecate/jstimezonedetect branch 2 times, most recently from c6dbc6a to 5a3c188 Compare October 12, 2019 13:20
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 3. to review Waiting for reviews labels Oct 12, 2019
@rullzer
Deprecate js globals
af995b8 
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the td/js_deprecate/jstimezonedetect branch from 5a3c188 to af995b8 Compare October 14, 2019 08:00
@rullzer rullzer merged commit b076e3a into master Oct 14, 2019
@rullzer rullzer deleted the td/js_deprecate/jstimezonedetect branch October 14, 2019 16:13
ChristophWurst added a commit to nextcloud/documentation that referenced this pull request Apr 10, 2020
@ChristophWurst
Update deprecated globals in 18
87cd5e9 
Ref nextcloud/server#17402
Ref nextcloud/server#17392

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst mentioned this pull request Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @ChristophWurst @skjnldsv