Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 4, 2019

🎵 We don't need no water, let the .... 🎵

@rullzer rullzer added 3. to review Waiting for reviews technical debt labels Oct 4, 2019
@rullzer rullzer added this to the Nextcloud 18 milestone Oct 4, 2019
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@rullzer rullzer requested a review from ChristophWurst October 4, 2019 17:32
@rullzer rullzer changed the title Deprecate global jstimezonedetect Deprecate a lot of global js Oct 5, 2019
@ChristophWurst
Copy link
Member

Mind using setDeprecatedProp instead? Then you get the warning as soon as you access the global. Reasoning: not everything is a function. Prime example: Backbone. You might use Backbone.Model or Backbone.Collection, but never do a Backbone(), hence the deprecate helper won't catch the access.

@rullzer
Copy link
Member Author

rullzer commented Oct 7, 2019

Mind using setDeprecatedProp instead? Then you get the warning as soon as you access the global. Reasoning: not everything is a function. Prime example: Backbone. You might use Backbone.Model or Backbone.Collection, but never do a Backbone(), hence the deprecate helper won't catch the access.

right makes sense.

@ChristophWurst

This comment has been minimized.

@rullzer rullzer force-pushed the td/js_deprecate/jstimezonedetect branch 2 times, most recently from c6dbc6a to 5a3c188 Compare October 12, 2019 13:20
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 3. to review Waiting for reviews labels Oct 12, 2019
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the td/js_deprecate/jstimezonedetect branch from 5a3c188 to af995b8 Compare October 14, 2019 08:00
@rullzer rullzer merged commit b076e3a into master Oct 14, 2019
@rullzer rullzer deleted the td/js_deprecate/jstimezonedetect branch October 14, 2019 16:13
ChristophWurst added a commit to nextcloud/documentation that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants