Fix oauth client redirect #17411
Merged
Fix oauth client redirect #17411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinolaev
force-pushed
the
fix-oauth2-redirect
branch
from
10ac2fd to
5c8f82f
Compare
rullzer
approved these changes
Oct 4, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
nice catch!
For bonus point tests would be cool! 😉
Signed-off-by: Sergej Nikolaev <[email protected]>
kinolaev
force-pushed
the
fix-oauth2-redirect
branch
from
5c8f82f to
1b5d85a
Compare
Member
Author
|
Hello @rullzer! Thank you for quick reply, I fixed a test. |
Member
Author
|
Hello @ChristophWurst, can you please review this small patch? Oauth authentication doesn’t work for now in Chrome. |
ChristophWurst
approved these changes
Oct 7, 2019
Member
|
/backport to stable17 |
|
backport to stable17 in #17438 |
|
Same error with nextcloud 20 in Chrome and new Edge browser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Chrome prevents redirect to oauth redirect url because of CSP 'form-action' on grant page. Firefox allows redirect from form submission responses but Chrome doesn't (see MDN, W3C).
Solution: allow oauth redirect url in CSP.