Skip to content

Throw an invalid token exception is token is marked outdated #17443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Dec 3, 2019
Merged

Throw an invalid token exception is token is marked outdated #17443

rullzer merged 1 commit into from
Dec 3, 2019

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 7, 2019 •
edited
Loading

This avoids hitting the backend with multiple requests for the same
token. And will help avoid quick LDAP lockouts.

@rullzer rullzer added enhancement 2. developing Work in progress labels Oct 7, 2019
@rullzer rullzer added this to the Nextcloud 18 milestone Oct 7, 2019
@rullzer rullzer requested a review from ChristophWurst October 7, 2019 12:07
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 15, 2019
@rullzer
Copy link
Member Author

rullzer commented Oct 15, 2019

I think this is good to go :)

ChristophWurst
ChristophWurst reviewed Oct 21, 2019
View reviewed changes
ChristophWurst
ChristophWurst reviewed Oct 29, 2019
View reviewed changes
@rullzer
Copy link
Member Author

rullzer commented Nov 13, 2019 •
edited
Loading

Review time

@blizzz this should help a bit with locked out LDAP stuff.
I think this was even one of the origianl use cases when we first talked about it

blizzz
blizzz approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@blizzz
Copy link
Member

blizzz commented Dec 2, 2019

I think this was even one of the origianl use cases when we first talked about it

Yes, when password changed on the backend. But it used to be working iirc?

@blizzz

This comment has been minimized.

Sign in to view
@rullzer @ChristophWurst
Throw an invalid token exception is token is marked outdated
b371e73 
This avoids hitting the backend with multiple requests for the same
token. And will help avoid quick LDAP lockouts.

Signed-off-by: Roeland Jago Douma <[email protected]>
@ChristophWurst ChristophWurst force-pushed the enh/expired_token_on_invalid_pass branch from 35facfc to b371e73 Compare December 2, 2019 17:57
@rullzer rullzer merged commit 9fce87b into master Dec 3, 2019
@rullzer rullzer deleted the enh/expired_token_on_invalid_pass branch December 3, 2019 07:59
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 3, 2019

/backport to stable17

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 3, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 3, 2019

backport to stable17 in #18198

@joshtrichards joshtrichards mentioned this pull request Mar 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@georgehrke georgehrke Awaiting requested review from georgehrke

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @blizzz @ChristophWurst