[stable17] Use @nextcloud/axios to keep the CSRF token in sync #17455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Oct 8, 2019
rullzer
changed the title
rullzer
force-pushed
the
fix/stable17-axios-package
branch
from
fe26f46 to
ea79bca
Compare
rullzer
approved these changes
Oct 14, 2019
skjnldsv
approved these changes
Oct 15, 2019
Member
|
/compile amend / |
Signed-off-by: Christoph Wurst <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix/stable17-axios-package
branch
from
ea79bca to
37cca6f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second of two partial backports of #17319
With this package update our Axios abstraction is able to listen to the CSRF token update event and adjust the Axios default accordingly. Otherwise it would use the initial CSRF token forever.
Testing is simple: go to the apps page, run
_nc_event_bus.emit('csrf-token-update', {token: 123})and try to enable/disable an app. The request will fail. This verifies that the event is properly handled by the updated lib.