Skip to content

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Oct 8, 2019

ref #17364

@GretaD GretaD requested review from jancborchardt and skjnldsv and removed request for jancborchardt October 8, 2019 15:58
@rullzer rullzer added 3. to review Waiting for reviews enhancement labels Oct 8, 2019
@rullzer rullzer added this to the Nextcloud 18 milestone Oct 8, 2019
@jancborchardt
Copy link
Member

@Bables55 @Octopus2 @AndyFx12 @DmDS @elpraga @justasomeone since you reported this in issue #17364, could you try testing and reviewing this fix? That helps a lot, thanks! :)

@Octopus2
Copy link

Octopus2 commented Oct 12, 2019

Screenshot_20191012-123741_Chrome

I changed the scss-file on my 17.0 installation. I used "maintenance:repair"in the console and cleared the browsercache to see these changes. It looks much better now. But there is no 3-dots-menu in root....

@Octopus2
Copy link

Screenshot_20191012-123555_Chrome

Interesting: Subfolders have a 3-dot-menu....

@Octopus2
Copy link

I played around on root: when i change the view from details to thumbnail and then back i get the three-dots-menu.... But its gone after reloading the page....

@elpraga
Copy link

elpraga commented Oct 12, 2019

I've just applied the patch. And everything seems to be working as expected. I can see even the three dot menu in the root folder.

@AndyFx12
Copy link

Sorry - but this fix seems not to work (or I did something wrong ...).

NC17.0 with fixes
Screenshot_20191013-203429

NC16.05:
Screenshot_20191013-203630

Andy

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@juliusknorr
Copy link
Member

@AndyFx12 We cache css files pretty heavily on production systems. Try running occ maintenance:repair after the patch is applied.

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2019
@juliusknorr
Copy link
Member

/backport to stable17

@jancborchardt
Copy link
Member

What about the Drone failure here? :)

@AndyFx12
Copy link

After occ maintenance:repair AND clear browser-cache it works fine:
Screenshot_20191025-143510

@skjnldsv skjnldsv merged commit 6d9bcb7 into master Oct 25, 2019
@skjnldsv skjnldsv deleted the bug/17364/fix_filename_overlapping_mobile branch October 25, 2019 12:59
@skjnldsv
Copy link
Member

What about the Drone failure here? :)

timeouts :)

@backportbot-nextcloud
Copy link

backport to stable17 in #17676

@jancborchardt
Copy link
Member

Hmm, it actually looks a bit strange, the share icon and the avatars are not horizontally aligned, but right-aligned?

@juliusknorr
Copy link
Member

@jancborchardt Please open a new issue. It is not really related as it was like that before. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants