Skip to content

Workflow frontend polishing #17506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 18 commits into from
Nov 4, 2019
Merged

Workflow frontend polishing #17506

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
327be37
Remove unused stylesheets from workflowengine
juliusknorr Oct 10, 2019
7147046
Fix remaining comments from #16706
juliusknorr Oct 10, 2019
b15c4a3
Properly validate individual checks
juliusknorr Oct 10, 2019
7b82a09
Fix minor styling issues with the user agent picker
juliusknorr Oct 10, 2019
6878d36
Allow to select multiple events
juliusknorr Oct 10, 2019
e72f58b
Fix bugs with check plugins
juliusknorr Oct 10, 2019
6830daf
Decode list of events when returning them
juliusknorr Oct 10, 2019
0fccda8
Fix input size and ellipsis
juliusknorr Oct 10, 2019
fce33f3
Fix operation list when scope is limited
juliusknorr Oct 11, 2019
06d43bd
Add missing ocs resource for user workflows
juliusknorr Oct 11, 2019
2adcc75
Fetch groups on the fly
juliusknorr Oct 11, 2019
928cf4b
Fix issue with unavailable operations
juliusknorr Oct 15, 2019
8a0164b
Adjust user UserWorkflowController methods to AWorflowController
juliusknorr Oct 15, 2019
5551da2
Fix systemtag selector
juliusknorr Oct 22, 2019
a0582ef
Move delete/cancel button to the bottom
juliusknorr Oct 23, 2019
580c835
Design fixes
juliusknorr Oct 23, 2019
9c766cf
do not break on Checkers that do not need specific context info
blizzz Oct 29, 2019
3f97025
bump bundles
blizzz Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix minor styling issues with the user agent picker 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr @blizzz
juliusknorr authored and blizzz committed Oct 29, 2019
commit 7b82a09a3b2fd19e5af9ac091f33236b1dc2cf44
13 changes: 12 additions & 1 deletion apps/workflowengine/src/components/Check.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<Multiselect v-model="currentOperator"
:disabled="!currentOption"
:options="operators"
class="comparator"
label="name"
track-by="operator"
:allow-empty="false"
Expand All @@ -21,6 +22,7 @@
v-model="check.value"
:disabled="!currentOption"
:check="check"
class="option"
@input="updateCheck"
@valid="(valid=true) && validate()"
@invalid="(valid=false) && validate()" />
Expand All @@ -30,6 +32,7 @@
:class="{ invalid: !valid }"
:disabled="!currentOption"
:placeholder="valuePlaceholder"
class="option"
@input="updateCheck">
<Actions v-if="deleteVisible || !currentOption">
<ActionButton icon="icon-delete" @click="$emit('remove')" />
Expand Down Expand Up @@ -110,7 +113,7 @@ export default {
},
validate() {
if (this.currentOption && this.currentOption.validate) {
this.valid = !!this.currentOption.validate(this.check);
this.valid = !!this.currentOption.validate(this.check)
}
return this.valid
},
Expand Down Expand Up @@ -139,6 +142,14 @@ export default {
& > *:not(.icon-delete) {
width: 180px;
}
& > .comparator {
min-width: 130px;
width: 130px;
}
& > .option {
min-width: 230px;
width: 230px;
}
& > .multiselect,
& > input[type=text] {
margin-right: 5px;
Expand Down
2 changes: 1 addition & 1 deletion apps/workflowengine/src/components/Checks/FileSystemTag.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<template>
<MultiselectTag v-model="newValue"
:multiple="false"
label="{{ t('workflowengine', 'Select a tag') }}"
:label="t('workflowengine', 'Select a tag')"
@input="update" />
</template>

Expand Down
21 changes: 19 additions & 2 deletions apps/workflowengine/src/components/Checks/RequestUserAgent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,16 @@
@input="setValue">
<template slot="singleLabel" slot-scope="props">
<span class="option__icon" :class="props.option.icon" />
<span class="option__title option__title_single">{{ props.option.label }}</span>
<!-- v-html can be used here as t() always passes our translated strings though DOMPurify.sanitize -->
<!-- eslint-disable-next-line vue/no-v-html -->
<span class="option__title option__title_single" v-html="props.option.label" />
</template>
<template slot="option" slot-scope="props">
<span class="option__icon" :class="props.option.icon" />
<span class="option__title">{{ props.option.label }} {{ props.option.$groupLabel }}</span>
<!-- eslint-disable-next-line vue/no-v-html -->
<span v-if="props.option.$groupLabel" class="option__title" v-html="props.option.$groupLabel" />
<!-- eslint-disable-next-line vue/no-v-html -->
<span v-else class="option__title" v-html="props.option.label" />
</template>
</Multiselect>
<input v-if="!isPredefined"
Expand Down Expand Up @@ -133,3 +138,15 @@ export default {
}
}
</script>
<style scoped>
.multiselect, input[type='text'] {
width: 100%;
}
.multiselect .multiselect__content-wrapper li>span,
.multiselect__single {
display: flex;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}
</style>