Pass on direct query parameter during login #17548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable17 |
ChristophWurst
approved these changes
Oct 15, 2019
ChristophWurst
added
4. to release
skjnldsv
reviewed
Oct 15, 2019
| :value="OC.requestToken"> | ||
| <input type="hidden" | ||
| name="direct" | ||
| :value="direct"> |
Member
There was a problem hiding this comment.
Suggested change
| :value="direct"> | |
| :value="directLogin"> |
WHy not use directLogin directly?
Member
There was a problem hiding this comment.
because the "direct" parameter is what we use in various places at the moment, including SAML and GS
Member
There was a problem hiding this comment.
yeah, but it's coming as a prop, so we don't care about the name of the variable :)
Member
|
tested it successfully! |
Member
|
would be great to have this in 17.0.1. I know some users waiting for it. |
Member
Author
|
It will be backported yes |
Member
Author
|
Ok so i changed the code a bit. |
skjnldsv
approved these changes
Oct 16, 2019
If direct is set we should forward it again. This to make SAML direct login work again. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
fix/saml/pass_on_direct
branch
from
a373b07 to
38730b4
Compare
ChristophWurst
approved these changes
Oct 16, 2019
|
The backport to stable17 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If direct is set we should forward it again.
This to make SAML direct login work again.
Signed-off-by: Roeland Jago Douma [email protected]