Skip to content

Remove type hint for AbstractTrash.getSize() #17609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scriptator wants to merge 2 commits into from
Closed

Remove type hint for AbstractTrash.getSize() #17609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
277bb5a
Remove type hint for AbstractTrash.getSize()
scriptator Oct 20, 2019
e4c27e5
Use multiline comment in AbstractTrash
scriptator Oct 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/files_trashbin/lib/Sabre/AbstractTrash.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ public function getFileInfo(): FileInfo {
return $this->data;
}

public function getSize(): int {
/**
* Removal of return type is intentional as int is not large enough on 32 bit systems
* see https://github.com/nextcloud/server/issues/13160
*/
public function getSize() {
return $this->data->getSize();
}

Expand Down