Fix weird KDE bug with loginflowv2 #17626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that KDE by default opens the url in secret. Should fix: nextcloud/desktop#1412 Signed-off-by: Roeland Jago Douma <[email protected]>
Member
Author
|
/backport to stable17 |
Member
Author
|
/backport to stable16 |
Contributor
|
How do you ensure that a token is not used twice? What do you think of adding setStarted to flowDone, set it to 2 and check for a value < 2 in startLoginFlow? |
Member
Author
We don't right now. The token gets cleared once the flow is completed. |
Contributor
|
Thanks @rullzer 👍 Missed |
ChristophWurst
approved these changes
Oct 22, 2019
kesselb
added
4. to release
kesselb
approved these changes
Oct 23, 2019
|
backport to stable17 in #17688 |
|
backport to stable16 in #17689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that KDE by default opens the url in secret.
Should fix: nextcloud/desktop#1412
Signed-off-by: Roeland Jago Douma [email protected]