Do not show 'Get your own free account' on services under subscription #17674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
juliusknorr,
nickvergessen,
skjnldsv and
tobiasKaminsky
kesselb
reviewed
Oct 25, 2019
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
enh/do_not_show_footer_sub
branch
from
ecc36c8 to
931c68c
Compare
kesselb
approved these changes
Oct 29, 2019
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
There is no way to show the signup link if you have a subscription. Guess that's acceptable.
Member
Author
yeah fine by me :) If somebody complains we'll see about it then. |
Member
Author
|
/backport to stable17 |
tobiasKaminsky
approved these changes
Oct 30, 2019
|
backport to stable17 in #17748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma [email protected]