Show first day of the week in correct language #17691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
skjnldsv
approved these changes
Oct 26, 2019
georgehrke
approved these changes
Oct 26, 2019
rullzer
reviewed
Oct 26, 2019
| escapeHTML: true, | ||
| oc_userconfig: true | ||
| oc_userconfig: true, | ||
| dayNames: true, |
Member
There was a problem hiding this comment.
We should start exposing this via a proper API. But different time ;)
rullzer
approved these changes
Oct 26, 2019
rullzer
added
4. to release
|
It doesn't work right. I set Language to "Deutsch" and Locale "Englisch(Irland)" and the calendar shows Sunday as the first day of the week. |
Member
That is an issue in the calendar, see nextcloud/calendar#1844 |
|
Ok thank you for your express reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up for #17673. Should be backportable without
.eslintrc.Master
This PR
