Return null from migration to match with typehint #17740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable17 |
Member
|
Why? The schema should only be returned when it actually changed something. Which is only the case inside the if? Otherwise this locks the db starts heavy diffing of the schema just to unlock again? |
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
fix/17479/always-return-schema
branch
from
5dcae6e to
fd83661
Compare
Contributor
Author
OK. It returns null outside the if now. |
kesselb
changed the title
nickvergessen
approved these changes
Oct 29, 2019
| $table->addIndex(['object_id'], 'calendar_reminder_objid'); | ||
| $table->addIndex(['uid', 'recurrence_id'], 'calendar_reminder_uidrec'); | ||
|
|
||
| return $schema; |
| return $schema; | ||
| } | ||
|
|
||
| return $schema; |
rullzer
approved these changes
Oct 29, 2019
|
backport to stable17 in #17742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17479