Catch file transfer error and stop transfer ownership command #17913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
MorrisJobke,
icewind1991,
nickvergessen,
rullzer and
sharidas
| if ($this->transfer($output) === false) { | ||
| $output->writeln('<error>Could not transfer files</error>'); | ||
| // Abort | ||
| return 1; |
Member
There was a problem hiding this comment.
Is the real error logged?
Member
Author
There was a problem hiding this comment.
Couldn't find out. Some exceptions are thrown, some are caught.
Member
Author
There was a problem hiding this comment.
Maybe a storage export like @icewind1991 or @rullzer can tell?
Member
There was a problem hiding this comment.
I guess here it is not possible...
rullzer
approved these changes
Nov 13, 2019
Member
|
I guess this needs a rebase then 😉 |
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/transfer-ownership-move-files-error-handling
branch
from
b3cd39a to
70f4e7e
Compare
Member
Author
Done. So much cleaner now :) |
rullzer
approved these changes
Nov 27, 2019
Member
|
Review time! |
nickvergessen
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #15664
This does not check quota as I do not have a clue how to do this. But it checks the returned value of the move operation. Better than nothing.