Skip to content

Extract transfer ownership logic into a reusable service #18025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Nov 26, 2019
Merged

Extract transfer ownership logic into a reusable service #18025

rullzer merged 1 commit into from
Nov 26, 2019

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 20, 2019

This will make

Tested with a simple guest account.

@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Nov 20, 2019
@ChristophWurst ChristophWurst self-assigned this Nov 20, 2019
nickvergessen
nickvergessen reviewed Nov 20, 2019
View reviewed changes
nickvergessen
nickvergessen reviewed Nov 20, 2019
View reviewed changes
@rullzer rullzer requested a review from icewind1991 November 20, 2019 11:17
nickvergessen
nickvergessen approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rullzer
rullzer approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 21, 2019
@ChristophWurst ChristophWurst mentioned this pull request Nov 21, 2019
Merged
2 tasks
@rullzer rullzer mentioned this pull request Nov 21, 2019
Merged
15 tasks
@rullzer
Copy link
Member

rullzer commented Nov 21, 2019

rebase and autosquash first ;)

@ChristophWurst ChristophWurst force-pushed the refactor/extract-ownership-transfer-service branch from e890a03 to 36ee58a Compare November 21, 2019 10:00
@ChristophWurst ChristophWurst mentioned this pull request Nov 22, 2019
Closed
@rullzer rullzer force-pushed the refactor/extract-ownership-transfer-service branch from 36ee58a to 44aa4f1 Compare November 25, 2019 07:42
@rullzer
Copy link
Member

rullzer commented Nov 26, 2019

And another rebase. But then we can get it in I guess

@rullzer rullzer force-pushed the refactor/extract-ownership-transfer-service branch from 44aa4f1 to 07c5f37 Compare November 26, 2019 07:50
@rullzer rullzer merged commit dfe85ae into master Nov 26, 2019
@rullzer rullzer deleted the refactor/extract-ownership-transfer-service branch November 26, 2019 08:32
@ChristophWurst ChristophWurst mentioned this pull request Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst @rullzer @nickvergessen