Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 28, 2019

Fix #17903, Fix #18137

Please review @Ases @finalls @markuman @markushagge @nursoda @j-ed

Otherwise it is passed as string and ignored by the Users Backend

private function fixLimit($limit) {
if (is_int($limit) && $limit >= 0) {
return $limit;
}
return null;
}

@skjnldsv
Copy link
Member Author

/backport to stable17

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2019
@skjnldsv
Copy link
Member Author

Lots of failures, are those related?

@kesselb
Copy link
Contributor

kesselb commented Nov 28, 2019

Lots of failures, are those related?

No. #18143

@kesselb
Copy link
Contributor

kesselb commented Nov 28, 2019

@skjnldsv
Copy link
Member Author

@kesselb
Copy link
Contributor

kesselb commented Nov 28, 2019

No 🤣 Sorry for the noise. I edited your post, changed the issue number (leading 1 was missing) and added another issue: Fix #17903, #18137 But this syntax is invalid and @gary-kim tried to fix it.

@nursoda
Copy link

nursoda commented Nov 28, 2019

Should I worry about "continuous-integration/drone/pr — Build is failing" or try to modify my production system with the PR?

@kesselb
Copy link
Contributor

kesselb commented Nov 28, 2019

Should I worry about "continuous-integration/drone/pr — Build is failing"

No. But if you patch your instance always make a backup.

@Ases
Copy link

Ases commented Nov 28, 2019

Please review @Ases @finalls @markuman @markushagge @nursoda @j-ed

It works!!! Thank you @skjnldsv

Copy link

@Ases Ases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the problem. 👍

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@rullzer rullzer force-pushed the fix/provisioning_api/users-typing branch from fa16a6e to f675e61 Compare November 28, 2019 19:28
@rullzer rullzer merged commit b552da5 into master Nov 29, 2019
@rullzer rullzer deleted the fix/provisioning_api/users-typing branch November 29, 2019 08:04
@backportbot-nextcloud
Copy link

backport to stable17 in #18157

@nursoda
Copy link

nursoda commented Nov 29, 2019

I applied the PR (added the four int type definitions). That solves the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups high regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nextcloud started duplicating users Users dont show after upgrade to Nextcloud 17.0.1

7 participants