-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix provisioning_api getUsers types #18142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable17 |
|
Lots of failures, are those related? |
No. #18143 |
wrong issue? |
|
No 🤣 Sorry for the noise. I edited your post, changed the issue number (leading 1 was missing) and added another issue: |
|
Should I worry about "continuous-integration/drone/pr — Build is failing" or try to modify my production system with the PR? |
No. But if you patch your instance always make a backup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solves the problem. 👍
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
fa16a6e to
f675e61
Compare
|
backport to stable17 in #18157 |
|
I applied the PR (added the four int type definitions). That solves the issue for me. |
Fix #17903, Fix #18137
Please review @Ases @finalls @markuman @markushagge @nursoda @j-ed
Otherwise it is passed as string and ignored by the Users Backend
server/lib/private/User/Database.php
Lines 491 to 497 in 1a886b1