Skip to content

Fix direct editing access check on Postgres #18152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Nov 28, 2019
Merged

Fix direct editing access check on Postgres #18152

blizzz merged 1 commit into from
Nov 28, 2019

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 28, 2019 •
edited
Loading

Postgres is returning a real boolean, so we need to cast the column value properly and not check for matching a 1

Fixes failing postgres tests that slipped in with #17625

@juliusknorr
Check for boolean value
6c92e4d 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr changed the title Check for boolean value Fix direct editing access check on Postgres Nov 28, 2019
@juliusknorr juliusknorr added 3. to review Waiting for reviews bug labels Nov 28, 2019
@juliusknorr juliusknorr added this to the Nextcloud 18 milestone Nov 28, 2019
@blizzz blizzz merged commit a6ae801 into master Nov 28, 2019
@blizzz blizzz deleted the bugfix/noid/direct-editing-postgres branch November 28, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@blizzz blizzz blizzz approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @rullzer @blizzz