Skip to content

Fix files app LoadSidebar event #18213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Dec 4, 2019
Merged

Fix files app LoadSidebar event #18213

skjnldsv merged 3 commits into from
Dec 4, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 3, 2019

Needed for the sidebar to properly init when launching the LoadSidebar event

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: file sidebar Related to the file sidebar component labels Dec 3, 2019
@skjnldsv skjnldsv added this to the Nextcloud 18 milestone Dec 3, 2019
@skjnldsv skjnldsv self-assigned this Dec 3, 2019
@skjnldsv skjnldsv mentioned this pull request Dec 3, 2019
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 4, 2019

/compile amend /

@skjnldsv @npmbuildbot
Fix files app LoadSidebar event
241aac9 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
rullzer
rullzer approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 4, 2019
@skjnldsv
Use own getIconUrl method
c1277ea 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 4, 2019
@skjnldsv
Properly query files
46ce797 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Dec 4, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 4, 2019

Had a small event race condition, fixed

@skjnldsv skjnldsv merged commit bfb9cce into master Dec 4, 2019
@skjnldsv skjnldsv deleted the feat/loadsidebar/files branch December 4, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@jakobroehrl jakobroehrl jakobroehrl approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @rullzer @jakobroehrl