Skip to content

Conversation

@ChristophWurst
Copy link
Member

This hasn't been done in a while. Thus the large diff.

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Dec 3, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Dec 3, 2019
@ChristophWurst ChristophWurst self-assigned this Dec 3, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2019

Should we have a test for it? :p
And a bot?

@rullzer
Copy link
Member

rullzer commented Dec 4, 2019

No bot.
We should just remember to run it once before a release or something.

Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2019
@rullzer rullzer merged commit 12bdb95 into master Dec 5, 2019
@rullzer rullzer deleted the fix/license-script branch December 5, 2019 18:46
@rullzer rullzer mentioned this pull request Dec 11, 2019
43 tasks
@skjnldsv
Copy link
Member

skjnldsv commented Dec 23, 2019

There was some weird changes, like this one

<?php
/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
* @author Arthur Schiwon <[email protected]>
* @author Bjoern Schiessle <[email protected]>
* @author Christoph Wurst <[email protected]>
* @author John Molakvoæ (skjnldsv) <[email protected]>
* @author Roeland Jago Douma <[email protected]>
*
* @license AGPL-3.0
*
* This code is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License, version 3,
* along with this program. If not, see <http://www.gnu.org/licenses/>
*
*/
// FIXME: disabled for now to be able to inject IGroupManager and also use
// getSubAdmin()
//declare(strict_types=1);
/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
* @author Arthur Schiwon <[email protected]>
* @author Bjoern Schiessle <[email protected]>
* @author Björn Schießle <[email protected]>
* @author Christoph Wurst <[email protected]>
* @author Clark Tomlinson <[email protected]>
* @author Joas Schilling <[email protected]>
* @author Lukas Reschke <[email protected]>
* @author Morris Jobke <[email protected]>
* @author Robin Appelman <[email protected]>

@kesselb
Copy link
Contributor

kesselb commented Dec 23, 2019

There was some weird changes, like this one

😨

grep -c -r --include \*.php  "is free software: you can redistribute it and\/or modify" . | grep -v -E ':0|:1'
./build/license.php:3
./apps/settings/lib/Controller/UsersController.php:2
./apps/settings/lib/Controller/ChangePasswordController.php:2
./apps/text/lib/Controller/DirectSessionController.php:2
./apps/text/lib/Controller/WorkspaceController.php:2
./apps/recommendations/lib/Service/RecentlyCommentedFilesSource.php:2

Seems to affect only a few files.

@kesselb
Copy link
Contributor

kesselb commented Jan 10, 2020

@ChristophWurst could you have a look at the broken files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants