Skip to content

confirm auth on share generated by Circles #18235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Dec 19, 2019
Merged

confirm auth on share generated by Circles #18235

rullzer merged 1 commit into from
Dec 19, 2019

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Dec 4, 2019

Signed-off-by: Maxence Lange [email protected]

@ArtificialOwl ArtificialOwl added this to the Nextcloud 18 milestone Dec 4, 2019
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Dec 4, 2019

late, but would be nice to have this implemented in NC18.

Allows using the Circles ShareProvider to check validity of Token used during federated shares.
This allow to have only one entry in the share table for a share to a circle, while having one token per member of the circle. Meaning that removing a member from a circle invalidate the share for this member.

Love.

@ArtificialOwl ArtificialOwl force-pushed the enh/noid/federated-on-circles branch from 252fb61 to 1065f58 Compare December 5, 2019 16:40
This was referenced Dec 11, 2019
Merged
Merged
@ArtificialOwl
confirm auth on share generated by Circles
3513833 
Signed-off-by: Maxence Lange <[email protected]>
returns true

Signed-off-by: Maxence Lange <[email protected]>
DI

Signed-off-by: Maxence Lange <[email protected]>
DI

Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/federated-on-circles branch from 1065f58 to 3513833 Compare December 16, 2019 12:01
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Dec 16, 2019

rebased as tests are fine locally.

@rullzer rullzer mentioned this pull request Dec 19, 2019
Merged
18 tasks
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Dec 19, 2019

@rullzer looks mergeable as the only issue is from a timeout

@rullzer rullzer merged commit eaf89d1 into master Dec 19, 2019
@rullzer rullzer deleted the enh/noid/federated-on-circles branch December 19, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@rullzer rullzer rullzer approved these changes

@blizzz blizzz blizzz approved these changes

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: sharing

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ArtificialOwl @rullzer @nickvergessen @blizzz